Fix tests failing with cargo test but not with cargo nextest
#12061
+27
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The difference between those two is whether each test gets its own process. So it was clear that we're leaking state. Turns out it's about store subscribers which often rely on unique store ids for distinguishing concrete stores.
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
grtlr
approved these changes
Dec 3, 2025
Member
grtlr
left a comment
grtlr
left a comment
There was a problem hiding this comment.
Oh my, that looks hard to find!
Is there a rule of thumb when to use StoreInfo::testing and when to set the recording id explicitly?
|
|
||
| /// Creates a new store info for testing purposes with a fixed store id. | ||
| /// | ||
| /// Most of the time we don't want to fix the store id since it is used as a key in static store subscribers. |
Member
There was a problem hiding this comment.
Suggested change
| /// Most of the time we don't want to fix the store id since it is used as a key in static store subscribers. | |
| /// Most of the time we don't want to fix the store id since it is used as a key in static store subscribers, which might not get teared down after every test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
The difference between those two is whether each test gets its own process. So it was clear that we're leaking state. Turns out it's about store subscribers which often rely on unique store ids for distinguishing concrete stores.
Solving this on the store subscriber level with the current arch is hard because the subscriber correctly accumulate data from all parallel running tests that do writes do stores with the exact same id